Re: [Partysip-dev] MAJOR release for osip and partysip.

[Fredrik Thulin]

On Monday 14 October 2002 18.57, Aymeric Moizard wrote:
> I'm pleased to announce new release of osip and partysip.
>
> libosip-0.9.0 contains mainly improvments in the parser and

Great. I've been waiting for this release to continue work on the ENUM plugin 
(however, my October has become very full of other activities so I'm not sure 
when I'll find the time).

Two problems:

The Date: headers my Cisco 7960 is sending in invites are parsed incorrectly :

Date: Tue, 15 Oct 2002 14:42:55 GMT

forwarded as 

date: Tue
date: 15 Oct 2002 14:42:55 GMT

I have not yet started tracking this down - maybe you know right away what is 
needed.

A worse problem :

When calling my SIP phone through a commercial SIP proxy, the following header 
is sent to partysip :

Proxy-Authorization: Digest 
username="address@hidden",realm="other.domain.example.com",
uri="sip:192.168.1.10",response="15d2e3a1b3af1e3e4cac32e60ec45116",
nonce="6acda19788645eb8ee3f991d8d5b1367",
opaque="0788cb7106dd0d9214a3dfcd7f11aff7",cnonce="555698a3",qop=auth,
nc=00000001,algorithm=md5

libosip tries to parse this in authorization_parse() but expects 'qop' to have 
a quoted argument and calls quoted_string_set() which fails. 'algorithm' is 
not expected to have a quoted argument and is parsed with token_set().

The problem is that quoted_string_set() returns stuff with qoutes around them, 
and token_set() not. I first tried to solve this by making 
quoted_string_set() capable of parsing non-quoted variables but it quickly 
got hairy when I started putting quotes around the non-quoted stuff and so 
on. In the name of robustness I beleive quoted_string_set() should be made 
the generic parser for these options and everything would be stored with or 
without quotes. What do you think and how much else depends on there 
being/not being qoutes around specific arguments?

/Fredrik