pdf-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pdf-devel] Built-in unit test framework


From: jemarch
Subject: Re: [pdf-devel] Built-in unit test framework
Date: Tue, 22 Apr 2008 21:27:06 +0200
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.60 (powerpc-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)

Hi Aleks.

   I finished the simple and small replacement of Check (No-Check):
   [...]
   I attach the changes and new files.

Very good work! I think that it perfectly fits our needs.

   > #Check for Check and No-Check :-)
   > if NOCHECK
   >   NOCHECK_SRC = nocheck/check.h \
   >                 nocheck/check.c
   >   NOCHECK_CFLAGS = -Inocheck/
   > else
   >   CHECK_LIBS = -lcheck
   > endif #NOCHECK

Only a little detail. The appropriate name for that NOCHECK_CFLAGS
would be NOCHECK_CPPFLAGS.

Please commit it and ACK.

Thanks.

-- 
Jose E. Marchesi  <address@hidden>
                  <address@hidden>

GNU Spain         http://es.gnu.org
GNU Project       http://www.gnu.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]