Re: [pdf-devel] FS module, file size and free space with different interface

[jemarch]

Hi Hans.

   just a minor one. The two functions

   pdf_size_t pdf_fsys_get_free_space (pdf_fsys_t file_system, 
                                       pdf_text_t path_name)

   pdf_status_t pdf_fsys_file_get_size (pdf_fsys_file_t file, 
                                        pdf_size_t *size)

   are very simelar, but provide a different interface. The first one
   returns the size, the second one stores it in a reference and
   returns a status code. Shouldn't both functions be used in the same
   way?

Yes, definitely. Since pdf_fsys_file_get_size operates in a
pdf_fsys_file_t and not in a path we can expect that should not be no
error in the execution of the function.

I would say to change the pdf_fsys_file_get size to

 pdf_size_t pdf_fsys_file_get_size (pdf_fsys_file_t file);