Re: [pdf-devel] [PATCH] Fix compilation on Open/FreeBSD

[Aleksander Morgado]

Hi there,

> I spent a little time over the three day weekend fixing compilation on
> Open/FreeBSD. NetBSD still isn't working, it seems to be an issue with
> linking to libiconv.

Which issue? If there is not an iconv() implementation already in the
system, the user can install GNU libiconv and it should work (in my
Ubuntu at home it worked even better with the GNU replacement, with no
'invalid reads' notified by valgrind).

If you give me more detail on the problem maybe I can help.

> 
> * Fix time function init to use struct tm rather than the linux-only
> "daylight/timezone" global variables. As a side note, using those was
> setting it incorrectly anyway with regard to daylight savings time and
> GMT offsets.

Which where the problems with the GMT offset and the daylight saving
time? Can you detail them? I didn't fully test those functions, so
probably you're right, but anyway I would like to have more details.

> 
> All the tests pass with this patch on Linux, FreeBSD and OpenBSD.

What about Windows and Mac OS X?


Thanks and regards!

-Aleksander