pdf-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pdf-devel] Stream buffer flaw


From: jemarch
Subject: Re: [pdf-devel] Stream buffer flaw
Date: Sat, 04 Oct 2008 14:35:09 +0200
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

   You can check the above prints are consistent (yet undesired) with the code,
   see:
   ##
   pdf_bool_t
   pdf_stm_buffer_full_p (pdf_stm_buffer_t buffer)
   {
     return ((buffer->wp == buffer->size) &&
             (buffer->rp != buffer->wp));
   }
   ###

The second part of the return expression is wrong: it should not be
there.

I just commited a patch in the trunk removing the second part of the
expression and the really_finish_p patch from yesterday.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]