[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pdf-devel] Crypt module
From: |
jemarch |
Subject: |
Re: [pdf-devel] Crypt module |
Date: |
Tue, 23 Dec 2008 23:47:56 +0100 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
> Hi David.
>
> It seems that the filters never return PDF_EEOF when finish_p equals
> to true: they return either PDF_ENINPUT or PDF_ERROR.
>
> + if (aux_size > out_size)
> + {
> + /* We should can return PDF_ENOUTPUT. However the
> + output buffer is assumed to be full if we return
> + PDF_ENOUTPUT, but we can not write it partially. */
> + return PDF_ERROR;
> + }
>
> The same problem that we found in the previous version: the filter
> should cache the output of the cypher and write it step by step,
> returning PDF_ENOUTPUT if the output buffer is not big enough to hold
> all the data.
>
> Did you send the right version of the filters?
Jemarch, the patch was for the crypt module with support for incremental
encryption.
Ah, sorry! XD
Anyway, can you please send a patch not containing the code for the
filters? We can apply the filters later.