|
From: | jemarch |
Subject: | Re: [pdf-devel] [PATCH] Token reader, with new API |
Date: | Wed, 20 May 2009 14:06:00 +0200 |
User-agent: | Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/23.0.92 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) |
Hi Michael. Here's a patch to add a token reader based on the documented API. I've also added and documented a pdf_token_equal_p function. The code hasn't changed much since the last tokeniser patch I sent, apart from being restructured for the new API. I reviewed your patch and everything is fine. Just a suggestion: to change pdf-token-obj.[ch] to pdf-token.[ch]. We usually store the implementation of the ADT pdf_foo_t on pdf-foo.[ch]. What do you think? (It is just a suggestion. If you strongly feel that it is ok to use pdf-token-obj.[ch] I will apply the patch as it is now). -- Jose E. Marchesi address@hidden GNU Project http://www.gnu.org
[Prev in Thread] | Current Thread | [Next in Thread] |