pdf-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pdf-devel] Fix for FS#113


From: Aleksander Morgado
Subject: Re: [pdf-devel] Fix for FS#113
Date: Mon, 05 Apr 2010 22:47:18 +0200

>     Basically, just made sure that pdf.h includes the proper
>     PDF_HAVE_* symbols defined before actually using them.
>     
>     A new template was added (pdf-config.h.in) which gets populated
>     with the proper symbol values once ./configure is run. The
>     generated pdf-config.h with all these 'public' symbol definitions
>     is then included at the beginning of pdf.h.
> 
> I think that we could avoid the usage of AC_SUBST and thus the need of
> maintaining the *_SUBST variables.
> 
> If we turn src/pdf-config.h.in into a headers template like:
> 
> -- begin of src/pdf-config.h.in
> ...
> 
> /* Set to 1 if forcing bignums.  */
> #undef PDF_FORCE_BIGNUMS
> 
> /* Set to 1 if ...  */
> #undef PDF_...
> 
> ...
> -- end of src/pdf-config.h.in
> 

Attached the patch using your approach, as it is quite more clear than
the one using the SUBST variables.

Comments welcome!

-Aleksander

Attachment: fs-113-rev2.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]