Re: [pdf-devel] Patch for FS#127

[Aleksander Morgado]

Hi Jonathan,

> This patch is addressing FS#127, changing pdf_text_s member 'data'
> from type pdf_char_t to pdf_uchar_t.  This is my first patch, I hope
> it looks alright-- if not, I will be ready to make changes as needed.
> 

Thanks for the patch. Some minor things here:
 * The "Date:" header in each source file represents the time when the
file was created, so you shouldn't modify it on every changed file.
 * Try to keep alignment of argument names in the method
declarations/definitions.

And, did you make sure that no unit test was broken with that change?

Cheers!

-- 
Aleksander

signature.asc
Description: This is a digitally signed message part