[pdf-devel] utils/pdf-filter.c: found 2 small problems/bugs?

[Georg Gottleuber]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

while testing the prediction filter I found 2 small problems/bugs in
utils/pdf-filter.c:

1.) Calling ./pdf-filter with "--lzwenc --lzw-earlychange" the
earlychange arg is ignored. Because of the getopt_long loop design args
will only have an effect if named before the FILTER. Most simple fix
would be to make call convention  [FILTER_ARGS FILTER]
instead of [FILTER FILTER_ARGS] (in the patch below)
But maybe it is more comfortable with some extra variables, so we can
call in any order. I can send a patch/merge directive for this too.

2.) Calling ./pdf-filter with stdin and (input length % BUF_SIZE == 0)
will run into a libgnupdf ASSERT, because fread returns 0 if stdin is
empty and puts this into pdf_stm_write call. (additional if added)

Patch to fix both problems is attached.

Regards,
Georg


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk4UNuAACgkQ5sLITM1qIaILcACeIKwuo5lzmwD2SpNJGsF/nUta
xywAn2Ox8WWPzedMWKgfEEOYiyTS8VtT
=s9eB
-----END PGP SIGNATURE-----

pdf-filter.c.patch
Description: Text document