Re: [Phpgroupware-developers] Proper time for history log (0.9.14)

[Eric Parusel]

Yes it is...  I don't have the time to check out HEAD, but this fix
works fine for me on 0.9.14 where it didn't work before :)
And it's quite a simple problem and fix, considering that the
history_log value wasn't being set at all -- so I just added it onto
the INSERT statement.

> Is this in .14? Try checking out HEAD... I submitted a
> patch for this a couple of weeks ago and it is already
> applied in HEAD. I believe it's the same issue.
>
> --- Eric Parusel <address@hidden> wrote:
> > The time wasn't being entered into the history log
> > for the todo application
> > (and maybe others), so I made this patch:
> >
> >
> >
> > --- class.historylog.inc.php    Wed Jan 30 16:34:34
> > 2002
> > +++ class.historylog.inc.php    Wed Jan 30 17:00:27
> > 2002
> > @@ -58,10 +58,10 @@
> >                         if ($new_value !=
> > $old_value)
> >                         {
> >
> > $this->db->query("insert into
> > phpgw_history_log (history_record_id,"
> > -                                       .
> >
>
"history_appname,history_owner,history_status,history_new_value,histor
y_old_
> > value) "
> > +                                       .
> >
>
"history_appname,history_owner,history_status,history_new_value,histor
y_old_
> > value,history_timestamp) "
> >                                         . "values
> > ('$record_id','" .
> > $this->appname . "','"
> >                                         .
> > $GLOBALS['phpgw_info']['user']['account_id'] .
> > "','$status','"
> > -                                       .
> > addslashes($new_value) . "','" .
> > addslashes($old_value) . "')",__LINE__,__FILE__);
> > +                                       .
> > addslashes($new_value) . "','" .
> > addslashes($old_value) . "','" .
> > $this->db->to_timestamp(time()) .
> > "')",__LINE__,__FILE__);
> >                         }
> >                 }
> >
> >
> >
> >
> >
> > _______________________________________________
> > Phpgroupware-developers mailing list
> > address@hidden
> >
> http://mail.gnu.org/mailman/listinfo/phpgroupware-developers
>
>
> __________________________________________________
> Do You Yahoo!?
> Great stuff seeking new owners in Yahoo! Auctions!
> http://auctions.yahoo.com
>
> _______________________________________________
> Phpgroupware-developers mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/phpgroupware-developers
>