[Phpgroupware-tracker] [bug #4354] etemplate saving errors on windows file already exists

[nobody]

=================== BUG #4354: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4354&group_id=509

Changes by: Ralf Becker <address@hidden>
Date: Mon 07/21/2003 at 18:06 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
This has been fixed in CVS and should be available in the next
release.



=================== BUG #4354: FULL BUG SNAPSHOT ===================


Submitted by: knackw                  Project: phpGroupWare                 
Submitted on: Fri 07/18/2003 at 13:15
Category:  eTemplates                 Bug Group:  0.9.16 pre RC             
Severity:  5 - Major                  Priority:  Normal                     
Resolution:  Fixed                    Assigned to:  ralfbecker              
Status:  Closed                       Component Version:  ZIP               
Platform Version:  Windows            Reproducibility:  Every Time          

Summary:  etemplate saving errors on windows file already exists

Original Submission:  it would be nice, even if you would change the following

class.db_tools.inc.php 

line 632 

from 

if (is_writable(PHPGW_SERVER_ROOT."/$app/setup")) 
{ 
rename($file,PHPGW_SERVER_ROOT."/$app/setup/setup.old.inc.php"); 
} 

to 

$old_file = PHPGW_SERVER_ROOT."/$app/setup/setup.old.inc.php"; 
if (is_writable(PHPGW_SERVER_ROOT."/$app/setup")) 
{ 
if (file_exists($old_file)) 
{ 
unlink($old_file); 
} 
rename($file,$old_file); 
} 

class.db_tools.inc.php 

line 566 

from 

if (is_writable(PHPGW_SERVER_ROOT."/$app/setup")) 
{ 
rename($file,PHPGW_SERVER_ROOT."/$app/setup/tables_current.old.inc.php"); 
} 

to 

$old_file = PHPGW_SERVER_ROOT."/$app/setup/tables_current.old.inc.php"; 
if (is_writable(PHPGW_SERVER_ROOT."/$app/setup")) 
{ 
if (file_exists($old_file)) 
{ 
unlink($old_file); 
} 
rename($file,$old_file); 
} 

class.db_tools.inc.php 

line 741 

from 

rename($file_update,PHPGW_SERVER_ROOT."/$app/setup/tables_update.old.inc.php"); 

to 

$old_file = PHPGW_SERVER_ROOT."/$app/setup/tables_update.old.inc.php"; 
if (file_exists($old_file)) 
{ 
unlink($old_file); 
} 
rename($file_update,$old_file); 

class.soetemplate.inc.php 

line 780 

from 

if (file_exists($file)) 
{ 
rename($file,"$dir/phpgw_$lang.old.lang"); 
} 

to 

$old_file = "$dir/phpgw_$lang.old.lang"; 
if (file_exists($file)) 
{ 
if (file_exists($old_file)) 
{ 
unlink($old_file); 
} 
rename($file,$old_file); 
} 

class.soetemplate.inc.php 

line 612 

from 

$file = "$dir/etemplates.inc.php"; 
if (file_exists($file)) 
{ 
rename($file,"$dir/etemplates.old.inc.php";); 
} 

to 

$file = "$dir/etemplates.inc.php"; 
$old_file = "$dir/etemplates.old.inc.php"; 
if (file_exists($file)) 
{ 
if (file_exists($old_file)) 
{ 
unlink($old_file); 
} 
rename($file,$old_file); 
} 


Follow-up Comments
*******************

-------------------------------------------------------
Date: Mon 07/21/2003 at 18:06       By: ralfbecker
This has been fixed in CVS and should be available in the next
release.


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4354&group_id=509

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/