[Pspp-cvs] pspp/src/data ChangeLog data-out.c

[Ben Pfaff]

CVSROOT:        /cvsroot/pspp
Module name:    pspp
Changes by:     Ben Pfaff <blp> 06/11/11 19:43:33

Modified files:
        src/data       : ChangeLog data-out.c 

Log message:
        Fix buffer overflow reported by John Darrington.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/pspp/src/data/ChangeLog?cvsroot=pspp&r1=1.73&r2=1.74
http://cvs.savannah.gnu.org/viewcvs/pspp/src/data/data-out.c?cvsroot=pspp&r1=1.10&r2=1.11

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/pspp/pspp/src/data/ChangeLog,v
retrieving revision 1.73
retrieving revision 1.74
diff -u -b -r1.73 -r1.74
--- ChangeLog   5 Nov 2006 05:20:53 -0000       1.73
+++ ChangeLog   11 Nov 2006 19:43:33 -0000      1.74
@@ -1,3 +1,10 @@
+Sat Nov 11 11:41:26 2006  Ben Pfaff  <address@hidden>
+
+       Fix buffer overflow reported by John Darrington.
+
+       * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
+       realize that DIGITS is a count of nibbles, not of bytes.
+
 Sat Nov  4 15:59:56 2006  Ben Pfaff  <address@hidden>
 
        * calendar.c (calendar_offset_to_gregorian) Also return the

Index: data-out.c
===================================================================
RCS file: /cvsroot/pspp/pspp/src/data/data-out.c,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -b -r1.10 -r1.11
--- data-out.c  5 Nov 2006 05:20:53 -0000       1.10
+++ data-out.c  11 Nov 2006 19:43:33 -0000      1.11
@@ -1026,7 +1026,7 @@
     }
   else 
     {
-      memset (output, 0, digits);
+      memset (output, 0, DIV_RND_UP (digits, 2));
       return false; 
     }
 }