[Pspp-cvs] pspp/src language/stats/regression.q language/s...

[Jason H Stover]

CVSROOT:        /sources/pspp
Module name:    pspp
Changes by:     Jason H Stover <jstover>        07/09/21 20:48:15

Modified files:
        src/language/stats: regression.q ChangeLog 
        src/math/linreg: linreg.c ChangeLog 

Log message:
        fix memory leaks; bug 21056

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/pspp/src/language/stats/regression.q?cvsroot=pspp&r1=1.63&r2=1.64
http://cvs.savannah.gnu.org/viewcvs/pspp/src/language/stats/ChangeLog?cvsroot=pspp&r1=1.66&r2=1.67
http://cvs.savannah.gnu.org/viewcvs/pspp/src/math/linreg/linreg.c?cvsroot=pspp&r1=1.24&r2=1.25
http://cvs.savannah.gnu.org/viewcvs/pspp/src/math/linreg/ChangeLog?cvsroot=pspp&r1=1.17&r2=1.18

Patches:
Index: language/stats/regression.q
===================================================================
RCS file: /sources/pspp/pspp/src/language/stats/regression.q,v
retrieving revision 1.63
retrieving revision 1.64
diff -u -b -r1.63 -r1.64
--- language/stats/regression.q 20 Sep 2007 04:48:14 -0000      1.63
+++ language/stats/regression.q 21 Sep 2007 20:48:14 -0000      1.64
@@ -1199,8 +1199,6 @@
              lopts.get_indep_mean_std[i] = 1;
            }
          models[k] = pspp_linreg_cache_alloc (X->m->size1, X->m->size2);
-         models[k]->indep_means = gsl_vector_alloc (X->m->size2);
-         models[k]->indep_std = gsl_vector_alloc (X->m->size2);
          models[k]->depvar = dep_var;
          /*
             For large data sets, use QR decomposition.

Index: language/stats/ChangeLog
===================================================================
RCS file: /sources/pspp/pspp/src/language/stats/ChangeLog,v
retrieving revision 1.66
retrieving revision 1.67
diff -u -b -r1.66 -r1.67
--- language/stats/ChangeLog    20 Sep 2007 04:48:13 -0000      1.66
+++ language/stats/ChangeLog    21 Sep 2007 20:48:14 -0000      1.67
@@ -1,3 +1,8 @@
+2007-09-21  Jason Stover  <address@hidden>
+
+       * regression.q (run_regression): Partial fix of memory leak, bug
+       21056.
+
 2007-09-19  Ben Pfaff  <address@hidden>
 
        Fix bug #21108.

Index: math/linreg/linreg.c
===================================================================
RCS file: /sources/pspp/pspp/src/math/linreg/linreg.c,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -b -r1.24 -r1.25
--- math/linreg/linreg.c        15 Sep 2007 00:52:59 -0000      1.24
+++ math/linreg/linreg.c        21 Sep 2007 20:48:14 -0000      1.25
@@ -189,6 +189,7 @@
        {
          pspp_coeff_free (c->coeff[i]);
        }
+      free (c->coeff);
       free (c);
     }
   return true;

Index: math/linreg/ChangeLog
===================================================================
RCS file: /sources/pspp/pspp/src/math/linreg/ChangeLog,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -b -r1.17 -r1.18
--- math/linreg/ChangeLog       12 Aug 2007 02:36:50 -0000      1.17
+++ math/linreg/ChangeLog       21 Sep 2007 20:48:14 -0000      1.18
@@ -1,3 +1,8 @@
+2007-09-21  Jason Stover  <address@hidden>
+
+       * linreg.c (pspp_linreg_cache_free): Partial fix of memory leak,
+       bug 21056.
+
 2007-08-11  Jason Stover  <address@hidden>
 
        * linreg.h (enum): Dropped ambiguous PSPP_LINREG_SVD in favor of