[Pspp-cvs] pspp/src/ui/gui ChangeLog text-data-import-dial...

[Ben Pfaff]

CVSROOT:        /cvsroot/pspp
Module name:    pspp
Changes by:     Ben Pfaff <blp> 08/05/08 23:58:56

Modified files:
        src/ui/gui     : ChangeLog text-data-import-dialog.c 

Log message:
        Don't make the user wiggle the mouse to be able to click on the
        Forward button twice in quick succession.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/pspp/src/ui/gui/ChangeLog?cvsroot=pspp&r1=1.125&r2=1.126
http://cvs.savannah.gnu.org/viewcvs/pspp/src/ui/gui/text-data-import-dialog.c?cvsroot=pspp&r1=1.4&r2=1.5

Patches:
Index: ChangeLog
===================================================================
RCS file: /cvsroot/pspp/pspp/src/ui/gui/ChangeLog,v
retrieving revision 1.125
retrieving revision 1.126
diff -u -b -r1.125 -r1.126
--- ChangeLog   8 May 2008 23:48:12 -0000       1.125
+++ ChangeLog   8 May 2008 23:58:56 -0000       1.126
@@ -2,14 +2,25 @@
 
        Patch #6505.  Reviewed by John Darrington.
 
-       * text-data-import-dialog: (struct assistant) New member
+       * text-data-import-dialog.c: Don't make the user wiggle the mouse
+       to be able to click on the Forward button twice in quick
+       succession.
+       (add_page_to_assistant): Mark pages in the assistant complete
+       immediately.
+       (on_prepare): No longer mark pages complete upon first visit.
+
+2008-05-08  Ben Pfaff  <address@hidden>
+
+       Patch #6505.  Reviewed by John Darrington.
+
+       * text-data-import-dialog.c: (struct assistant) New member
        `watch_cursor'.
-       (revise_fields_preview) Change the mouse pointer to a watch to
+       (revise_fields_preview): Change the mouse pointer to a watch to
        indicate that a long operation is ongoing.
-       (prepare_formats_page) Ditto.
-       (on_variable_change) Ditto.
-       (push_watch_cursor) New function.
-       (pop_watch_cursor) New function.
+       (prepare_formats_page): Ditto.
+       (on_variable_change): Ditto.
+       (push_watch_cursor): New function.
+       (pop_watch_cursor): New function.
 
 2008-05-08  John Darrington <address@hidden>
 

Index: text-data-import-dialog.c
===================================================================
RCS file: /cvsroot/pspp/pspp/src/ui/gui/text-data-import-dialog.c,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- text-data-import-dialog.c   8 May 2008 23:48:12 -0000       1.4
+++ text-data-import-dialog.c   8 May 2008 23:58:56 -0000       1.5
@@ -633,6 +633,7 @@
   gtk_assistant_append_page (ia->asst.assistant, content);
   gtk_assistant_set_page_type (ia->asst.assistant, content, type);
   gtk_assistant_set_page_title (ia->asst.assistant, content, title_copy);
+  gtk_assistant_set_page_complete (ia->asst.assistant, content, true);
 
   free (title_copy);
 
@@ -656,11 +657,6 @@
     gtk_widget_show (ia->asst.paste_button);
   else
     gtk_widget_hide (ia->asst.paste_button);
-
-  /* Make the user visit each page in the assistant once.  Seems
-     like a reasonable user interface, plus visiting the final
-     page is what constructs the dictionary. */
-  gtk_assistant_set_page_complete (assistant, page, true);
 }
 
 /* Called when the Cancel button in the assistant is clicked. */