[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #5818] relocation
From: |
Ben Pfaff |
Subject: |
[patch #5818] relocation |
Date: |
Sun, 25 Mar 2007 22:02:19 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1) |
Update of patch #5818 (project pspp):
Status: Ready For Test/Review => Works For Me
_______________________________________________________
Follow-up Comment #1:
Thank you for preparing this. It looks good to me. I have only a few
comments:
I don't know what's going on with the -rpath flags, but I'll assume that you
do.
I'm a little uncomfortable using macros for XML_NEW, PIXBUF_NEW_FROM_FILE,
instead of functions, but it's not a big deal.
I suspect that there are other places we should be using relocate, but it
should be easy to fix these as we find them.
As for the strings in version.c, I guess we could write a relocate_path
function that applies relocate to each directory in a path.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5818>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/