pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch #6071] Resing/Deleting/Inserting variables in GUI


From: John Darrington
Subject: Re: [patch #6071] Resing/Deleting/Inserting variables in GUI
Date: Wed, 18 Jul 2007 08:53:18 +0800
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Jul 17, 2007 at 08:47:44AM -0700, Ben Pfaff wrote:
     
     The example clarifies things for me.  Let's just go with your
     patch for now.  As long as you're willing to make dict_pad_values
     static and fix that assertion, I'm happy with it now.
     
     I am starting to think that perhaps the assignment of
     "case_index"es should be handled by a separate object.  But I
     don't know whether it's worth it.

I think that I arrived at a similar conclusion.

     Maybe it can be a cleanup
     later, if it helps.  Let's just use your code for now.

I've checked this in with your suggestions.  I also moved a couple of
prototypes from dictionary.h to vardict.h since they shouldn't be used
promiscuously.

J'

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.


Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]