Re: [patch #6219] Descriptives Dialog

[Ben Pfaff]

John Darrington <address@hidden> writes:

> On Tue, Oct 02, 2007 at 03:24:51AM +0000, Ben Pfaff wrote:
>      
>      Your patch is "obviously correct", thanks.
>      
>      Now I know about g_free.
>
> I don't think the changes I made to stat_label_cell_data_func are in
> fact causing the problem.  I made those just to be safe.
>
> The real problem in this instance is, I think, that you had called
> g_string_append AFTER you had assigned text to string->str.  The
> API ref for GString says "The str field points to the character
> data. It may move as text is added."

Definitely.  But the change to stat_label_cell_data_func let me
know that the g_* functions for allocation existed, of which I
had been blissfully ignorant heretofore.  It is good to know
about them so I can write code GTK-correctly.

I have additional comments and questions before this is ready to
be committed.  Coming up!
-- 
Ben Pfaff 
http://benpfaff.org