[patch #6254] Reader for gnumeric files

[Ben Pfaff]

Update of patch #6254 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           

    _______________________________________________________

Follow-up Comment #1:

This looks good.  Thank you for writing it.  I have a few nits:

+If the SHEET subcommand is omitted, then the command will read the
+first sheet in file.

"in file" => "in the file"

The documentation doesn't say how GET DATA decides whether a column is
numeric or string.

It appears that the changes to data/dictionary.c have already been checked
in.

In parse_get_data_command, it would be nice to distinguish entirely
unsupported formats from those for which support is simply not compiled in. 
This could be done, for example, by defining a parse_get_gnm that simply emits
an error message like "Support for Gnumeric files was not compiled into this
installation of PSPP" when !GNM_SUPPORT.

I just skimmed the code for Gnumeric files.  I will assume that it works,
especially since there's a test.

It looks like you're planning to check binary file Book1.gnumeric into the
tree.  Since Gnumeric files are just gzipped XML, I'd prefer to have the
un-zipped version checked in (Gnumeric is perfectly happy to read un-zipped
files too).  If you want to test the ability to read gzipped Gnumeric files,
you could run gzip on the file in the test.

(I know we have a few gzipped files in the tree already, but that's only
because they were absurdly large without it.)

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6254>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/