Re: [PATCH] gui: Fix sense of "Flag Significant Correlations" checkbox.

[John Darrington]

I'm not sure if this is just a typo in the SPSS documentation 
or what.   I'd be interested to know what thier software actually
does.

On Mon, Aug 09, 2010 at 07:03:22AM -0700, Ben Pfaff wrote:
     How odd.
     
     I'll drop this patch, then.
     
     Thank you for the review.
     
     John Darrington <address@hidden> writes:
     
     > According to the SPSS (v17) manual "SIG" means do NOT flag
     > significant values, and "NOSIG" means DO flag them.  
     >
     > On Sun, Aug 08, 2010 at 03:07:06PM -0700, Ben Pfaff wrote:
     >      This was doing the opposite of what it should have.
     >      
     >      Reported by Harry Thijssen <address@hidden>.
     >      ---
     >       src/ui/gui/correlation-dialog.c |    6 +++---
     >       1 files changed, 3 insertions(+), 3 deletions(-)
     >      
     >      diff --git a/src/ui/gui/correlation-dialog.c 
b/src/ui/gui/correlation-dialog.c
     >      index afc2344..84157cf 100644
     >      --- a/src/ui/gui/correlation-dialog.c
     >      +++ b/src/ui/gui/correlation-dialog.c
     >      @@ -1,5 +1,5 @@
     >       /* PSPPIRE - a graphical user interface for PSPP.
     >      -   Copyright (C) 2009  Free Software Foundation
     >      +   Copyright (C) 2009, 2010  Free Software Foundation
     >       
     >          This program is free software: you can redistribute it and/or 
modify
     >          it under the terms of the GNU General Public License as 
published by
     >      @@ -164,9 +164,9 @@ generate_syntax (const struct correlation *rd)
     >       
     >       
     >         if (gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON 
(rd->significant)))
     >      -    g_string_append (string, " NOSIG");
     >      -  else
     >           g_string_append (string, " SIG");
     >      +  else
     >      +    g_string_append (string, " NOSIG");
     >       
     >       
     >         g_string_append (string, ".\n");
     >      -- 
     >      1.7.1
     >      
     >      
     >      _______________________________________________
     >      pspp-dev mailing list
     >      address@hidden
     >      http://lists.gnu.org/mailman/listinfo/pspp-dev
     
     -- 
     Ben Pfaff 
     http://benpfaff.org

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature