[PATCH 0/9] sys-file-reader fixes and tests

[Ben Pfaff]

This series of patches adds a bunch of unit tests for the system
file reader code in PSPP and fixes a few bugs that I found as I was
writing the tests.

Ben Pfaff (9):
  hash-functions: Use C instead of preprocessor to test size of double.
  sys-file-reader: Fix double-free on read of partial record.
  sys-file-reader: Check that multiple response set names begin with
    `$'.
  sys-file-reader: Add missing periods at end of error messages.
  sys-file-reader: Really enable warnings for invalid variable formats.
  sys-file-reader: Improve debugging usefulness of error messages.
  sys-file-reader: Avoid redundant "within system file" in messages.
  sys-file-reader: Elevate invalid number of labels from warning to
    error.
  sys-file-reader: Add tests.

 Smake                           |    1 +
 configure.ac                    |    4 +-
 doc/dev/system-file-format.texi |    4 +-
 src/data/sys-file-reader.c      |   60 +-
 src/libpspp/hash-functions.c    |   27 +-
 tests/atlocal.in                |    1 +
 tests/automake.mk               |    7 +
 tests/data/sack.c               |  499 ++++++
 tests/data/sys-file-reader.at   | 3315 +++++++++++++++++++++++++++++++++++++++
 9 files changed, 3870 insertions(+), 48 deletions(-)
 create mode 100644 tests/data/sack.c
 create mode 100644 tests/data/sys-file-reader.at