pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] PSPP shared library refinements


From: bojo42
Subject: Re: [PATCH 0/2] PSPP shared library refinements
Date: Mon, 30 Jan 2012 15:04:20 +0100

Upload to mentors done.

But before you might push that on to FTP, there are a few small issues:

- GUI: when i open psppire on an Ubuntu 12.04 development installation,
the window is quite "minimized", meaning you only see the menu and
toolbars, but no cells until you maximize the window. Where does that
might come from?

- Logo: having watched the redone SVG logo, i can't stand but to dig
another time into Inkscape to get that top element transparent or at
least the top border right. I will try to do that in the next days and
when you could then push it into Git, i would update the package again.

Am Samstag, den 28.01.2012, 09:20 -0800 schrieb Ben Pfaff:
> Thanks.  I ran "make distcheck" (thank you for the reminder) and
> pushed this.
> 
> bojo42, can you generate a new Debian package?
> 
> Thanks,
> 
> Ben.
> 
> John Darrington <address@hidden> writes:
> 
> > After we talked about this last night, I concluded this change was probably
> > appropriate.   There may come a time when people start using the core 
> > libraries
> > directly (like the perl module does) in which case we might have to 
> > consider moving, at least parts of the libraries back again.
> >
> > But for now, if make distcheck passes then we can commit this.
> >
> > On Thu, Jan 26, 2012 at 10:08:55PM -0800, Ben Pfaff wrote:
> >      These two patches make a few improvements in PSPP's shared libraries.
> >      I noticed that these could be improved while looking over the Debian
> >      packaging from bojo42.
> >      
> >      There is very little that makes me more nervous than messing around
> >      with shared libraries.  John, do these seem like reasonable changes?
> >      
> >      Thanks,
> >      
> >      Ben.
> >      
> >      Ben Pfaff (2):
> >        Name the src/libpspp convenience library consistently.
> >        Move PSPP shared libraries from $(libdir) to $(libdir)/pspp.
> >      
> >       configure.ac            |    2 +-
> >       perl-module/automake.mk |    8 +++++---
> >       src/automake.mk         |    4 ++--
> >       src/libpspp/automake.mk |   10 ++++++----
> >       tests/automake.mk       |   36 +++++++++++++++++++-----------------
> >       5 files changed, 33 insertions(+), 27 deletions(-)
> >      
> >      -- 
> >      1.7.2.5
> 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]