Re: [PATCH 00/13] second batch of psppsheet changes

[John Darrington]

Numbers 2/13   and 4-13/13 look fine to me.

J'

On Mon, Apr 16, 2012 at 08:52:06PM -0700, Ben Pfaff wrote:
     Here's another batch of changes that prepare for my work on the
     GUI data and variable sheets.  Many of these changes simply fix
     minor bugs and style issues and do little improvements to
     infrastructure.
     
     Feedback welcomed.  I'll give this a few days or until I hear back
     on reviews.
     
     Thanks,
     
     Ben.
     
     Ben Pfaff (13):
       psppire-dict: g_return_if_fail for idx in
         psppire_dict_get_variable().
       gui: Use canonical names for signals.
       gui: Add undocumented --measure-startup option.
       gui: Call g_thread_init() earlier.
       format: New functions fmt_change_width(), fmt_change_decimals().
       format: Introduce a new type "enum fmt_use".
       format: Fix typo in comment.
       helper: New function value_to_text__().
       value-labels: New function val_labs_find_value().
       abt: Drop child parameters from 'reaugment' function.
       abt: New function abt_is_empty().
       range-set: Rename "insert" function "set1", "delete" to "set0".
       range-set: New macro RANGE_SET_FOR_EACH to make iteration easier.
     
      src/data/datasheet.c                    |   13 +--
      src/data/format.c                       |  157 
++++++++++++++++++------------
      src/data/format.h                       |   24 ++++--
      src/data/value-labels.c                 |   31 ++++++-
      src/data/value-labels.h                 |    4 +-
      src/language/data-io/data-list.c        |    4 +-
      src/language/data-io/placement-parser.c |   27 +++---
      src/language/data-io/placement-parser.h |    7 +-
      src/language/data-io/print.c            |    4 +-
      src/libpspp/abt.c                       |   10 +-
      src/libpspp/abt.h                       |   43 +++++----
      src/libpspp/range-set.c                 |    8 +-
      src/libpspp/range-set.h                 |   21 +++--
      src/libpspp/sparse-xarray.c             |   18 ++--
      src/libpspp/tower.c                     |   32 +++----
      src/ui/gui/helper.c                     |   21 ++++-
      src/ui/gui/helper.h                     |    2 +
      src/ui/gui/main.c                       |   37 +++++++-
      src/ui/gui/psppire-dict.c               |   12 +--
      tests/libpspp/abt-test.c                |   16 ++--
      tests/libpspp/range-set-test.c          |   15 ++--
      21 files changed, 312 insertions(+), 194 deletions(-)
     
     -- 
     1.7.2.5
     
     
     _______________________________________________
     pspp-dev mailing list
     address@hidden
     https://lists.gnu.org/mailman/listinfo/pspp-dev

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature