pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Minor(ish) changes to PsppireValueEntry


From: Ben Pfaff
Subject: Re: Minor(ish) changes to PsppireValueEntry
Date: Mon, 23 Apr 2012 21:16:16 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

John Darrington <address@hidden> writes:

> From 45af0b16f93d7e810659f827fc076e8e8601404a Mon Sep 17 00:00:00 2001
> From: John Darrington <address@hidden>
> Date: Mon, 23 Apr 2012 21:38:17 +0200
> Subject: [PATCH 4/5] PsppireValueEntry: Use 
> gtk_combo_box_set_button_sensitivity instead of gtk_widget_sensitivity
>
> ---
>  src/ui/gui/psppire-value-entry.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/ui/gui/psppire-value-entry.c 
> b/src/ui/gui/psppire-value-entry.c
> index 44ad2d0..efe92da 100644
> --- a/src/ui/gui/psppire-value-entry.c
> +++ b/src/ui/gui/psppire-value-entry.c
> @@ -219,6 +219,9 @@ psppire_value_entry_init (PsppireValueEntry *obj)
>  
>    g_signal_connect (buffer, "notify::text",
>                      G_CALLBACK (psppire_value_entry_text_changed), obj);
> +
> +  gtk_combo_box_entry_set_text_column (GTK_COMBO_BOX_ENTRY (obj), COL_LABEL);
> +  gtk_combo_box_set_button_sensitivity (GTK_COMBO_BOX (obj), 
> GTK_SENSITIVITY_AUTO);
>  }

I'm not sure that the gtk_combo_box_set_button_sensitivity() call
is necessary, because the documentation for the
button-sensitivity property says that GTK_SENSITIVITY_AUTO is the
default.

But the patch looks OK to me.  Thank you.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]