[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug37999 08/11] RANK: Simplify rank_sorted_file() with new function
From: |
Ben Pfaff |
Subject: |
Re: [bug37999 08/11] RANK: Simplify rank_sorted_file() with new function sum_weights(). |
Date: |
Sat, 2 Feb 2013 09:40:05 -0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Feb 01, 2013 at 09:28:18AM -0800, Ben Pfaff wrote:
> On Fri, Feb 01, 2013 at 05:52:05PM +0100, John Darrington wrote:
> > On Thu, Jan 31, 2013 at 10:03:30PM -0800, Ben Pfaff wrote:
> > This makes the code easier to read and possibly even faster.
> >
> > - casereader_split (input, &pass1, &pass2);
> > -
> >
> > I think this is the only user of this function. If we don't need it
> > anymore I think it can be deleted.
>
> Fair enough, it's an odd function. I'll check for other users and
> remove it if I don't see any.
I added a commit that removes casereader_split() and pushed this series.
I don't know whether you were done reviewing it; if you do have any
comments then I'm happy to address them with additional commits.
- [bug37999 01/11] casegrouper: Add comments., (continued)
- [bug37999 01/11] casegrouper: Add comments., Ben Pfaff, 2013/02/01
- [bug37999 04/11] RANK: Lowercase the name of "enum RANK_FUNC"., Ben Pfaff, 2013/02/01
- [bug37999 05/11] RANK: Remove write-only struct member 'ascending'., Ben Pfaff, 2013/02/01
- [bug37999 03/11] transformations: Relax the rules for transformation finalizing., Ben Pfaff, 2013/02/01
- [bug37999 06/11] RANK: Put #include directives into typical order., Ben Pfaff, 2013/02/01
- [bug37999 02/11] subcase: New function subcase_add_vars_always()., Ben Pfaff, 2013/02/01
- [bug37999 07/11] RANK: Simplify fraction_name() function., Ben Pfaff, 2013/02/01
- [bug37999 08/11] RANK: Simplify rank_sorted_file() with new function sum_weights()., Ben Pfaff, 2013/02/01
- [bug37999 09/11] RANK: Create all variables together, in order., Ben Pfaff, 2013/02/01
- [bug37999 11/11] RANK: Add support for temporary transformations., Ben Pfaff, 2013/02/01
- [bug37999 10/11] RANK: Adopt a new ranking implementation., Ben Pfaff, 2013/02/01