Re: [PATCH] Multiboot

[Yoshinori K. Okuji]

On Thursday 13 November 2003 17:27, Jeroen Dekkers wrote:
> I've written multiboot support for PUPA. I haven't implemented all
> features in the Multiboot Specification but this should be enough to
> boot most kernels.

Great!

> Besides the multiboot code, I've added the string function
> pupa_stpcpy, copied from glibc's stpcpy(), and pupa_loader_unset(),
> which removes a loaded kernel. This is useful in the case when you've
> to deal with memory which need to be freed when a new kernel is
> loaded. I've also removed the check whether the unload function fails
> because pupa_loader_set() itself can't return an error.

That's all reasonable.

I'd like you to ask these changes on your patch:

* Rename pupa_multi_boot to pupa_multiboot_boot.
* Add what features in Multiboot are not supported at the moment as comments.

Okuji