Re: [Pyatcron-devel-list] New stuff for the upcoming week

[Julien Olivier]

On Tue, 2004-04-27 at 16:26, NICOLOVICI Xavier wrote:
> Hi everyone,
> 

Hi Xavier !

> First of all, Julien, I've applied your latest patch against the CVS tree and 
> commit changes to it. Result sounds good for me, but I hadn't spent much time 
> on your changes.
> 

Thanks.

> In fact, I've worked on something new in our design. As of today, we were 
> using a ScheduleList object that was dealing with Cron and At parser to build 
> a list of Scheduler. Then, this ScheduleList was used to feed a 
> Gtk::ListStore object attached to the Gtk::TreeView of the main window.
> 

Right.

> Ok, this approach force us to have a *huge* amount of code for synchronizing 
> our ScheduleList object and the Gtk::ListStore. This is really not a smart 
> object oriented approach.
> 

I concur.

> The idea I had is very basic, and I'm sure that you've already understood 
> what I will explain now; I've made our ScheduleList class a child of the 
> Gtk::ListStore class, and set it as model to the Gtk::TreeView object of our 
> main window. The result is a smaller and smarter code to manage events like 
> delete or add Schedulers.
> 

That's smart. I wonder why I didn't think of it when I first wrote the
task list :)

> This new class is named ScheduleListStore and is part of the lib.gui module. 
> I've attached a patch to add the needed code and a "test.py" file which 
> demonstrate how the mainwin.py module could be rewritten. Julien, if you 
> agree with this approach, let me know if you would like to do the work on the 
> mainwin.py module or if I should.
> 

The problem is that your patch appears as "winmail.dat". I don't know
how to open it... Could you re-send it in text/raw please ?

Apart from that, I would be glad to do the changes, but I won't have
much time in the following week because of "real work". So if you (or
anyone) have more free time, feel free to do it. However, if you decide
to work on it, just tell it to me so that I don't start to work on it
too...

> Julien, one remark about the callback method in the mainwin.py module. Could 
> you please use the same name for the call back method as the signal name? 
> This will let us connect signals to callback automatically without managing 
> dictionnaries.
> 

Yes, you're right. I'll do it the same way you do it in gui.py. It's
easier to manage.

-- 
Julien Olivier <address@hidden>