qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH Trivial V2] hw/intc/arm_gic: Remove the definition


From: Michael Tokarev
Subject: Re: [Qemu-arm] [PATCH Trivial V2] hw/intc/arm_gic: Remove the definition of NUM_CPU
Date: Fri, 06 Nov 2015 11:14:09 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0

05.11.2015 20:24, Wei Huang wrote:
> arm_gic.c retrieves CPU number using either NUM_CPU(s) or s->num_cpu.
> Such mixed-uses make source code inconsistent. This patch removes
> NUM_CPU(s), which was defined for MPCore tweak long ago, and instead
> favors s->num_cpu. The source is more consistent after this small tweak.
> 
> Reviewed-by: Andreas Färber <address@hidden>
> Signed-off-by: Wei Huang <address@hidden>

Reviewed-by: Michael Tokarev <address@hidden>

I'm not applying this to -trivial per previous comments.

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]