[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] nseries: Don't use qemu_hw_version()
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-arm] [PATCH] nseries: Don't use qemu_hw_version() |
|
Date: |
Thu, 12 Nov 2015 13:04:23 -0200 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Nov 12, 2015 at 01:39:24PM +0200, Michael S. Tsirkin wrote:
> On Wed, Nov 11, 2015 at 07:42:47PM -0200, Eduardo Habkost wrote:
> > nseries doesn't use qemu_set_hw_version() and doesn't need the
> > compatibility magic of qemu_hw_version(). Use QEMU_VERSION
> > directly.
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
>
> This looks very wrong.
> We should be reducing the users of QEMU_VERSION,
> not adding more.
I would like to hear from the users and maintainers of the
nseries machines, to judge this. I assume they don't need ABI
compatibility betweeen QEMU versions, and maybe they want to know
the QEMU version they are running.
--
Eduardo