Re: [Qemu-arm] [PATCH 1/2] target-arm: Update condexec before CP access check in AA32 translation

[Peter Maydell]

On 17 November 2015 at 10:59, Sergey Fedorov <address@hidden> wrote:
> On 16.11.2015 22:34, Sergey Fedorov wrote:
>> Coprocessor access instructions are allowed inside IT block.
>> gen_helper_access_check_cp_reg() can raise an exceptions thus condexec
>> bits should be updated before.
>>
>> Signed-off-by: Sergey Fedorov <address@hidden>
>> ---
>>  target-arm/translate.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/target-arm/translate.c b/target-arm/translate.c
>> index 4351854..f1f8129 100644
>> --- a/target-arm/translate.c
>> +++ b/target-arm/translate.c
>> @@ -7210,6 +7210,7 @@ static int disas_coproc_insn(DisasContext *s, uint32_t 
>> insn)
>>                  break;
>>              }
>>
>> +            gen_set_condexec(dc);
>
> Ah, there must be gen_set_condexec(s).

Yep. Are you going to resend?

thanks
-- PMM