Re: [Qemu-arm] [PATCH] target-arm/translate-a64.c: Correct unallocated checks for ldst_excl

[Sergey Fedorov]

On 24.11.2015 14:03, Peter Maydell wrote:
> On 23 November 2015 at 18:54, Sergey Fedorov <address@hidden> wrote:
>> On 23.11.2015 21:42, Sergey Fedorov wrote:
>>> On 23.11.2015 19:49, Peter Maydell wrote:
>>>> Ping? I forgot to mark this for-2.5, and given how long the bug's
>>>> been hanging around there's not much urgency to fixing it, but
>>>> we might as well put the fix into 2.5 if it gets reviewed.
>>>>
>>> Hi, Peter. I'm going to review this carefully in a few days :)
>>> For now, I see that the comment for this function should be updated to
>>> match new code.
>>>
>> However, I've just checked the logic of the patch was correct. Just the
>> comment needs to be adjusted.
> Looking through the rest of the file, in general we don't try
> to note in the instruction-format comments all the unallocated
> encoding possibilities, so I think the simplest thing will be
> just to delete that part of the comment. I don't think duplicating
> the information in the code itself really gains us much.
>
> I'll send out a v2.
>

I would just agree with you. No need to duplicate that low-level
knowledge which is obvious from the code.

Best regards,
Sergey