[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v3 3/8] hw/arm/virt-acpi-build: Add p
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v3 3/8] hw/arm/virt-acpi-build: Add power button device in ACPI DSDT table |
Date: |
Tue, 1 Dec 2015 12:41:27 +0100 |
On Mon, 16 Nov 2015 21:23:04 +0800
address@hidden wrote:
> From: Shannon Zhao <address@hidden>
>
> Add power button device in ACPI DSDT table.
>
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>
> Reviewed-by: Wei Huang <address@hidden>
> Tested-by: Wei Huang <address@hidden>
> ---
> hw/arm/virt-acpi-build.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index bf6b934..b25c90b 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -340,6 +340,18 @@ static void acpi_dsdt_add_gpio(Aml *scope, const
> MemMapEntry *gpio_memmap,
> aml_append(scope, dev);
> }
>
> +static void acpi_dsdt_add_power_button(Aml *scope)
> +{
> + Aml *dev = aml_device("PWRB");
> + aml_append(dev, aml_name_decl("_HID", aml_string("PNP0C0C")));
> + aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
> + aml_append(dev, aml_name_decl("_UID", aml_int(0)));
> + Aml *method = aml_method("_STA", 0);
> + aml_append(method, aml_return(aml_int(0x0F)));
> + aml_append(dev, method);
since _STA always returns 0xF you can just drop it altogether,
as _STA == 0xF is implied if it's not present.
> + aml_append(scope, dev);
> +}
> +
> /* RSDP */
> static GArray *
> build_rsdp(GArray *rsdp_table, GArray *linker, unsigned rsdt)
> @@ -558,6 +570,7 @@ build_dsdt(GArray *table_data, GArray *linker,
> VirtGuestInfo *guest_info)
> guest_info->use_highmem);
> acpi_dsdt_add_gpio(scope, &memmap[VIRT_GPIO],
> (irqmap[VIRT_GPIO] + ARM_SPI_BASE));
> + acpi_dsdt_add_power_button(scope);
>
> aml_append(dsdt, scope);
>
- Re: [Qemu-arm] [Qemu-devel] [PATCH v3 3/8] hw/arm/virt-acpi-build: Add power button device in ACPI DSDT table,
Igor Mammedov <=