Re: [Qemu-arm] [PATCH v4 5/8] target-arm: support QMP dump-guest-memory

[Peter Maydell]

On 11 January 2016 at 19:56, Andrew Jones <address@hidden> wrote:
> Add the support needed for creating prstatus elf notes. This
> allows us to use QMP dump-guest-memory.
>
> Signed-off-by: Andrew Jones <address@hidden>
> ---
>  target-arm/Makefile.objs |   3 +-
>  target-arm/arch_dump.c   | 230 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  target-arm/cpu-qom.h     |   5 ++
>  target-arm/cpu.c         |   3 +
>  4 files changed, 239 insertions(+), 2 deletions(-)
>  create mode 100644 target-arm/arch_dump.c

> --- a/target-arm/cpu.c
> +++ b/target-arm/cpu.c
> @@ -1429,6 +1429,9 @@ static void arm_cpu_class_init(ObjectClass *oc, void 
> *data)
>
>      cc->disas_set_info = arm_disas_set_info;
>
> +    cc->write_elf64_note = arm_cpu_write_elf64_note;
> +    cc->write_elf32_note = arm_cpu_write_elf32_note;
> +

This doesn't compile for the linux-user builds. I've moved the
assignments inside an #ifdef CONFIG_USER_ONLY guard in the
copy of this patch in target-arm.next.

thanks
-- PMM