[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v12 8/9] hw/ptimer: Perform delayed tick instead of im
From: |
Dmitry Osipenko |
Subject: |
[Qemu-arm] [PATCH v12 8/9] hw/ptimer: Perform delayed tick instead of immediate if delta = 0 |
Date: |
Sat, 30 Jan 2016 19:43:17 +0300 |
It might be necessary by some emulated HW to perform the tick after one
period if delta = 0. Given that it is much less churny to implement immediate
tick by the ptimer user itself, let's make ptimer do the delayed tick.
Signed-off-by: Dmitry Osipenko <address@hidden>
---
hw/core/ptimer.c | 34 +++++++++++++++-------------------
1 file changed, 15 insertions(+), 19 deletions(-)
diff --git a/hw/core/ptimer.c b/hw/core/ptimer.c
index b2044fb..bcd090c 100644
--- a/hw/core/ptimer.c
+++ b/hw/core/ptimer.c
@@ -36,19 +36,7 @@ static void ptimer_reload(ptimer_state *s)
{
uint32_t period_frac = s->period_frac;
uint64_t period = s->period;
-
- if (s->delta == 0) {
- ptimer_trigger(s);
- }
-
- if (s->delta == 0 && s->enabled == 1) {
- s->delta = s->limit;
- }
-
- if (s->delta == 0) {
- ptimer_stop(s);
- return;
- }
+ uint64_t delta = MAX(1, s->delta);
/*
* Artificially limit timeout rate to something
@@ -59,15 +47,15 @@ static void ptimer_reload(ptimer_state *s)
* on the current generation of host machines.
*/
- if (s->enabled == 1 && (s->delta * period < 10000) && !use_icount) {
- period = 10000 / s->delta;
+ if (s->enabled == 1 && (delta * period < 10000) && !use_icount) {
+ period = 10000 / delta;
period_frac = 0;
}
s->last_event = s->next_event;
- s->next_event = s->last_event + s->delta * period;
+ s->next_event = s->last_event + delta * period;
if (period_frac) {
- s->next_event += ((int64_t)period_frac * s->delta) >> 32;
+ s->next_event += ((int64_t)period_frac * delta) >> 32;
}
timer_mod(s->timer, s->next_event);
}
@@ -75,8 +63,16 @@ static void ptimer_reload(ptimer_state *s)
static void ptimer_tick(void *opaque)
{
ptimer_state *s = (ptimer_state *)opaque;
- s->delta = 0;
- ptimer_reload(s);
+
+ s->delta = (s->enabled == 1) ? s->limit : 0;
+
+ if (s->delta == 0) {
+ s->enabled = 0;
+ } else {
+ ptimer_reload(s);
+ }
+
+ ptimer_trigger(s);
}
uint64_t ptimer_get_count(ptimer_state *s)
--
2.7.0
- [Qemu-arm] [PATCH v12 0/9] PTimer fixes/features and ARM MPTimer conversion, Dmitry Osipenko, 2016/01/30
- [Qemu-arm] [PATCH v12 2/9] hw/ptimer: Perform counter wrap around if timer already expired, Dmitry Osipenko, 2016/01/30
- [Qemu-arm] [PATCH v12 1/9] hw/ptimer: Fix issues caused by the adjusted timer limit value, Dmitry Osipenko, 2016/01/30
- [Qemu-arm] [PATCH v12 3/9] hw/ptimer: Update .delta on period/freq change, Dmitry Osipenko, 2016/01/30
- [Qemu-arm] [PATCH v12 4/9] hw/ptimer: Support "on the fly" timer mode switch, Dmitry Osipenko, 2016/01/30
- [Qemu-arm] [PATCH v12 5/9] hw/ptimer: Introduce ptimer_get_limit, Dmitry Osipenko, 2016/01/30
- [Qemu-arm] [PATCH v12 7/9] hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active timer, Dmitry Osipenko, 2016/01/30
- [Qemu-arm] [PATCH v12 6/9] hw/ptimer: Legalize running with delta = load = 0 and abort on period = 0, Dmitry Osipenko, 2016/01/30
- [Qemu-arm] [PATCH v12 8/9] hw/ptimer: Perform delayed tick instead of immediate if delta = 0,
Dmitry Osipenko <=
- [Qemu-arm] [PATCH v12 9/9] arm_mptimer: Convert to use ptimer, Dmitry Osipenko, 2016/01/30