[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 07/11] target-arm: Add Hyp mode checks to bad_mode
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-arm] [PATCH 07/11] target-arm: Add Hyp mode checks to bad_mode_switch() |
Date: |
Thu, 18 Feb 2016 20:43:31 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 15.02.2016 20:22, Peter Maydell wrote:
> We don't actually support Hyp mode yet, but add the correct
> checks for it to the bad_mode_switch() function for completeness.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Sergey Fedorov <address@hidden>
> ---
> target-arm/helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 37b5439..4074b97 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -5184,6 +5184,9 @@ static int bad_mode_switch(CPUARMState *env, int mode)
> * allows FIQ mode to be Secure-only. (In v8 this doesn't exist.)
> */
> return 0;
> + case ARM_CPU_MODE_HYP:
> + return !arm_feature(env, ARM_FEATURE_EL2)
> + || arm_current_el(env) < 2 || arm_is_secure(env);
> case ARM_CPU_MODE_MON:
> return !arm_is_secure(env);
> default:
- Re: [Qemu-arm] [PATCH 02/11] target-arm: Add write_type argument to cpsr_write(), (continued)
- [Qemu-arm] [PATCH 06/11] target-arm: Add comment about not implementing NSACR.RFR, Peter Maydell, 2016/02/15
- [Qemu-arm] [PATCH 10/11] target-arm: Make mode switches from Hyp via CPS and MRS illegal, Peter Maydell, 2016/02/15
- [Qemu-arm] [PATCH 09/11] target-arm: In v8, make illegal AArch32 mode changes set PSTATE.IL, Peter Maydell, 2016/02/15
- [Qemu-arm] [PATCH 11/11] target-arm: Make Monitor->NS PL1 mode changes illegal if HCR.TGE is 1, Peter Maydell, 2016/02/15
- [Qemu-arm] [PATCH 07/11] target-arm: Add Hyp mode checks to bad_mode_switch(), Peter Maydell, 2016/02/15
- Re: [Qemu-arm] [PATCH 07/11] target-arm: Add Hyp mode checks to bad_mode_switch(),
Sergey Fedorov <=
- [Qemu-arm] [PATCH 01/11] target-arm: Give CPSR setting on 32-bit exception return its own helper, Peter Maydell, 2016/02/15