[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-arm] [PATCH v8 3/8] device_tree: introduce qemu_fdt_node_path
From: |
Eric Auger |
Subject: |
[Qemu-arm] [PATCH v8 3/8] device_tree: introduce qemu_fdt_node_path |
Date: |
Fri, 19 Feb 2016 13:17:08 +0000 |
This new helper routine returns a NULL terminated array of
node paths matching a node name and a compat string.
Signed-off-by: Eric Auger <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
v7 -> v8:
- don't use g_slist_free_full anymore (glib 2.28)
v6 -> v7:
- add Peter's R-b
v5 -> v6:
- in case of error, free the resources and return NULL
- update the doc comment
v4 -> v5:
- support the case where several nodes exist, ie.
return an array of node paths. Also add Error **
parameter
v1 -> v2:
- move doc comment in header file
- do not use a fixed size buffer
- break on errors in while loop
- use strcmp instead of strncmp
RFC -> v1:
- improve error handling according to Alex' comments
---
device_tree.c | 54 ++++++++++++++++++++++++++++++++++++++++++++
include/sysemu/device_tree.h | 18 +++++++++++++++
2 files changed, 72 insertions(+)
diff --git a/device_tree.c b/device_tree.c
index 9e77c69..b29a433 100644
--- a/device_tree.c
+++ b/device_tree.c
@@ -226,6 +226,60 @@ static int findnode_nofail(void *fdt, const char
*node_path)
return offset;
}
+char **qemu_fdt_node_path(void *fdt, const char *name, char *compat,
+ Error **errp)
+{
+ int offset, len, ret;
+ const char *iter_name;
+ unsigned int path_len = 16, n = 0;
+ GSList *path_list = NULL, *iter;
+ char **path_array;
+
+ offset = fdt_node_offset_by_compatible(fdt, -1, compat);
+
+ while (offset >= 0) {
+ iter_name = fdt_get_name(fdt, offset, &len);
+ if (!iter_name) {
+ offset = len;
+ break;
+ }
+ if (!strcmp(iter_name, name)) {
+ char *path;
+
+ path = g_malloc(path_len);
+ while ((ret = fdt_get_path(fdt, offset, path, path_len))
+ == -FDT_ERR_NOSPACE) {
+ path_len += 16;
+ path = g_realloc(path, path_len);
+ }
+ path_list = g_slist_prepend(path_list, path);
+ n++;
+ }
+ offset = fdt_node_offset_by_compatible(fdt, offset, compat);
+ }
+
+ if (offset < 0 && offset != -FDT_ERR_NOTFOUND) {
+ error_setg(errp, "%s: abort parsing dt for %s/%s: %s",
+ __func__, name, compat, fdt_strerror(offset));
+ for (iter = path_list; iter; iter = iter->next) {
+ g_free(iter->data);
+ }
+ g_slist_free(path_list);
+ return NULL;
+ }
+
+ path_array = g_new(char *, n + 1);
+ path_array[n--] = NULL;
+
+ for (iter = path_list; iter; iter = iter->next) {
+ path_array[n--] = iter->data;
+ }
+
+ g_slist_free(path_list);
+
+ return path_array;
+}
+
int qemu_fdt_setprop(void *fdt, const char *node_path,
const char *property, const void *val, int size)
{
diff --git a/include/sysemu/device_tree.h b/include/sysemu/device_tree.h
index 62093ba..552df21 100644
--- a/include/sysemu/device_tree.h
+++ b/include/sysemu/device_tree.h
@@ -25,6 +25,24 @@ void *load_device_tree(const char *filename_path, int
*sizep);
void *load_device_tree_from_sysfs(void);
#endif
+/**
+ * qemu_fdt_node_path: return the paths of nodes matching a given
+ * name and compat string
+ * @fdt: pointer to the dt blob
+ * @name: node name
+ * @compat: compatibility string
+ * @errp: handle to an error object
+ *
+ * returns a newly allocated NULL-terminated array of node paths.
+ * Use g_strfreev() to free it. If one or more nodes were found, the
+ * array contains the path of each node and the last element equals to
+ * NULL. If there is no error but no matching node was found, the
+ * returned array contains a single element equal to NULL. If an error
+ * was encountered when parsing the blob, the function returns NULL
+ */
+char **qemu_fdt_node_path(void *fdt, const char *name, char *compat,
+ Error **errp);
+
int qemu_fdt_setprop(void *fdt, const char *node_path,
const char *property, const void *val, int size);
int qemu_fdt_setprop_cell(void *fdt, const char *node_path,
--
1.8.3.2
- [Qemu-arm] [PATCH v8 0/8] AMD XGBE KVM platform passthrough, Eric Auger, 2016/02/19
- [Qemu-arm] [PATCH v8 2/8] device_tree: introduce load_device_tree_from_sysfs, Eric Auger, 2016/02/19
- [Qemu-arm] [PATCH v8 3/8] device_tree: introduce qemu_fdt_node_path,
Eric Auger <=
- [Qemu-arm] [PATCH v8 1/8] hw/vfio/platform: amd-xgbe device, Eric Auger, 2016/02/19
- [Qemu-arm] [PATCH v8 4/8] device_tree: qemu_fdt_getprop converted to use the error API, Eric Auger, 2016/02/19
- [Qemu-arm] [PATCH v8 5/8] device_tree: qemu_fdt_getprop_cell converted to use the error API, Eric Auger, 2016/02/19
- [Qemu-arm] [PATCH v8 7/8] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation, Eric Auger, 2016/02/19
- [Qemu-arm] [PATCH v8 8/8] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check, Eric Auger, 2016/02/19
- [Qemu-arm] [PATCH v8 6/8] hw/arm/sysbus-fdt: helpers for clock node generation, Eric Auger, 2016/02/19