[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v9 4/5] acpi: arm: add fw_cfg device node to dsdt
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-arm] [PATCH v9 4/5] acpi: arm: add fw_cfg device node to dsdt |
Date: |
Tue, 23 Feb 2016 11:51:29 +0200 |
On Fri, Feb 19, 2016 at 01:20:28PM -0500, Gabriel L. Somlo wrote:
> Add a fw_cfg device node to the ACPI DSDT. This is mostly
> informational, as the authoritative fw_cfg MMIO region(s)
> are listed in the Device Tree. However, since we are building
> ACPI tables, we might as well be thorough while at it...
>
> Signed-off-by: Gabriel Somlo <address@hidden>
> Reviewed-by: Laszlo Ersek <address@hidden>
> Tested-by: Laszlo Ersek <address@hidden>
> Reviewed-by: Marc MarĂ <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/arm/virt-acpi-build.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> index 8cf9a21..7d7998b 100644
> --- a/hw/arm/virt-acpi-build.c
> +++ b/hw/arm/virt-acpi-build.c
> @@ -81,6 +81,20 @@ static void acpi_dsdt_add_uart(Aml *scope, const
> MemMapEntry *uart_memmap,
> aml_append(scope, dev);
> }
>
> +static void acpi_dsdt_add_fw_cfg(Aml *scope, const MemMapEntry
> *fw_cfg_memmap)
> +{
> + Aml *dev = aml_device("FWCF");
> + aml_append(dev, aml_name_decl("_HID", aml_string("QEMU0002")));
> + /* device present, functioning, decoding, not shown in UI */
> + aml_append(dev, aml_name_decl("_STA", aml_int(0xB)));
> +
> + Aml *crs = aml_resource_template();
> + aml_append(crs, aml_memory32_fixed(fw_cfg_memmap->base,
> + fw_cfg_memmap->size, AML_READ_WRITE));
> + aml_append(dev, aml_name_decl("_CRS", crs));
> + aml_append(scope, dev);
> +}
> +
> static void acpi_dsdt_add_flash(Aml *scope, const MemMapEntry *flash_memmap)
> {
> Aml *dev, *crs;
> @@ -548,6 +562,7 @@ build_dsdt(GArray *table_data, GArray *linker,
> VirtGuestInfo *guest_info)
> acpi_dsdt_add_uart(scope, &memmap[VIRT_UART],
> (irqmap[VIRT_UART] + ARM_SPI_BASE));
> acpi_dsdt_add_flash(scope, &memmap[VIRT_FLASH]);
> + acpi_dsdt_add_fw_cfg(scope, &memmap[VIRT_FW_CFG]);
> acpi_dsdt_add_virtio(scope, &memmap[VIRT_MMIO],
> (irqmap[VIRT_MMIO] + ARM_SPI_BASE),
> NUM_VIRTIO_TRANSPORTS);
> acpi_dsdt_add_pci(scope, memmap, (irqmap[VIRT_PCIE] + ARM_SPI_BASE),
> --
> 2.4.3
- [Qemu-arm] [PATCH v9 0/5] add ACPI node for fw_cfg on pc and arm, Gabriel L. Somlo, 2016/02/19
- [Qemu-arm] [PATCH v9 4/5] acpi: arm: add fw_cfg device node to dsdt, Gabriel L. Somlo, 2016/02/19
- [Qemu-arm] [PATCH v9 2/5] pc: fw_cfg: move ioport base constant to pc.h, Gabriel L. Somlo, 2016/02/19
- [Qemu-arm] [PATCH v9 5/5] fw_cfg: document ACPI device node information, Gabriel L. Somlo, 2016/02/19
- [Qemu-arm] [PATCH v9 1/5] fw_cfg: expose control register size in fw_cfg.h, Gabriel L. Somlo, 2016/02/19
- [Qemu-arm] [PATCH v9 3/5] acpi: pc: add fw_cfg device node to dsdt, Gabriel L. Somlo, 2016/02/19
- Re: [Qemu-arm] [Qemu-devel] [PATCH v9 0/5] add ACPI node for fw_cfg on pc and arm, Igor Mammedov, 2016/02/22