|
From: | xiaoqiang zhao |
Subject: | Re: [Qemu-arm] [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model |
Date: | Fri, 27 May 2016 10:06:04 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
在 2016年05月25日 21:08, Peter Maydell 写道:
- > /* AUX / UART1 */ >- /* TODO: don't call qemu_char_get_next_serial() here, instead set >- * chardev properties for each uart at the board level, once pl011 >- * (uart0) has been updated to avoid qemu_char_get_next_serial() >- */This comment says this should be fixed by having board-level properties; you've removed it but this patch isn't adding the properties to this (SoC-level) device. I think the board level should be looking at serial_hds[], not this code.
Hi, Peter:I found bcm2835-peripherals is only used by bcm2836 code, you mean this(bcm2836) is the 'board level' and I should set chardev properties here ?
Thanks.
[Prev in Thread] | Current Thread | [Next in Thread] |