Re: [Qemu-arm] [PATCH 2/5] hw/arm/virt: set is_default

[Peter Maydell]

On 8 June 2016 at 19:24, Andrew Jones <address@hidden> wrote:
> Make the latest machine type (currently only one) the
> default.
>
> Signed-off-by: Andrew Jones <address@hidden>
> ---
>  hw/arm/virt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index a0d35d0826590..09afbafde025d 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1432,6 +1432,7 @@ static void virt_2_6_class_init(ObjectClass *oc, void 
> *data)
>
>      mc->desc = "QEMU 2.6 ARM Virtual Machine";
>      mc->alias = "virt";
> +    mc->is_default = 1;
>  }
>
>  static const TypeInfo machvirt_2_6_info = {

We don't want a default machine for 32-bit ARM, and I'm still
unconvinced we want a default machine for 64-bit ARM. At least,
this should be a separate patch/discussion from adding the
virt-2.7 machine type.

thanks
-- PMM