qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v2 1/6] target-i386: cpu: consolidate calls of obj


From: Igor Mammedov
Subject: Re: [Qemu-arm] [PATCH v2 1/6] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr
Date: Fri, 10 Jun 2016 09:24:10 +0200

On Thu, 9 Jun 2016 14:29:00 -0300
Eduardo Habkost <address@hidden> wrote:

> On Thu, Jun 09, 2016 at 07:10:58PM +0200, Igor Mammedov wrote:
> [...]
> > +
> > +    if (local_err) {
> > +        error_propagate(errp, local_err);
> >      }  
> 
> error_propagate() already ignores local_err==NULL so you don't
> need to check it first.
> 
> I can change this while applying the patch, if you're OK.
sounds good to me.

> 
> Reviewed-by: Eduardo Habkost <address@hidden>
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]