Re: [Qemu-arm] [RFC PATCH v1 2/4] exec.c: Remove static allocation of sub_section of sub_page

[Vijay Kilari]

Hi Paolo,

On Mon, Jun 13, 2016 at 3:22 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 13/06/2016 11:08, address@hidden wrote:
>> From: Vijaya Kumar K <address@hidden>
>>
>> Allocate sub_section dynamically. Remove dependency
>> on TARGET_PAGE_SIZE to make run-time page size detection
>> for arm platforms.
>>
>> Signed-off-by: Vijaya Kumar K <address@hidden>
>> ---
>>  exec.c |    5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/exec.c b/exec.c
>> index a9d465b..e803a41 100644
>> --- a/exec.c
>> +++ b/exec.c
>> @@ -154,7 +154,7 @@ typedef struct subpage_t {
>>      MemoryRegion iomem;
>>      AddressSpace *as;
>>      hwaddr base;
>> -    uint16_t sub_section[TARGET_PAGE_SIZE];
>> +    uint16_t *sub_section;
>
> Please make this a flexible array member instead, so that you can avoid
> the extra pointer dereference.

What do you mean by flexible array member?. please give more info.