|
From: | Richard Henderson |
Subject: | Re: [Qemu-arm] [PATCH v2] Improve the alignment check infrastructure |
Date: | Thu, 23 Jun 2016 09:12:59 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 06/23/2016 07:13 AM, Sergey Sorokin wrote:
I think we ought to check this in tcg-op.c, rather than wait until generating code in the backend.I think it's better to check this in one place in get_alignment_bits() function because there can be a direct call of helpers from softmmu_template.h.
I'm talking about the asserts in tcg/*/tcg-target.inc.c. Those asserts are better done in once place in tcg_canonicalize_memop.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |