|
From: | Richard Henderson |
Subject: | Re: [Qemu-arm] [RFC v3 PATCH 03/14] tcg/aarch64: Add support for fence |
Date: | Thu, 23 Jun 2016 09:50:56 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 06/23/2016 09:18 AM, Alex Bennée wrote:
> + /* System instructions. */ > + DMB_ISH = 0xd50338bf,As ISH is part of the CRm encoding I wonder if this should be split into the main DMB encoding (0xd50330bf) and a separate set of CRm defines. In fact the documentation of the struct above implies you should probably have: I6260_DMB = 0xd50330bf, And then: static void tcg_out_insn_6260(TCGContext *s, AArch64Insn insn, int crm); { tcg_out32(s, insn | (crm & 0xf) << 8); }
I don't see any benefit to doing this over or-ing in the pre-shifted values. r~
[Prev in Thread] | Current Thread | [Next in Thread] |