|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-arm] [PATCH v3 06/11] tcg: Introduce tb_mark_invalid() and tb_is_invalid() |
Date: | Thu, 14 Jul 2016 13:48:34 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 14/07/2016 13:10, Sergey Fedorov wrote: > > This has merge conflicts with the current state of master. Is there > > anyway to have a common implementation that is specialised only when > > needed? > > The point was to put the assumptions on invalid CPU TB state as close to > cpu_get_tb_cpu_state() definitions as possible. So that if anyone make > changes they can notice those assumptions and correct them if necessary. It causes some repetition indeed, but I think it's a good idea. restore_state_to_opc is another case where most implementations have the same simple "env->pc = data[0]" implementation. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |