[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 3/6] ast2400: use machine cpu_model to initialize
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-arm] [PATCH 3/6] ast2400: use machine cpu_model to initialize the soc cpu |
Date: |
Thu, 28 Jul 2016 08:59:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 |
On 07/28/2016 04:37 AM, Andrew Jeffery wrote:
> I did a similar thing in the series introducing the AST2400 SoC, and
> Peter had a comment on the approach[1]:
>
> What we do now is not let the user override the cpu model at all;
> presumably this SoC only ever has an ARM926 and it doesn't make
> any sense to have some frankenstein "this SoC but with a different
> CPU in it" config.
>
> Given this is the ast2400_init() it looks to me like we should be
> hardwiring the CPU rather than leaving it to the machine to define.
ok. so if we consider that the platform did the setting, we can reduce
the patch to :
- s->cpu = cpu_arm_init("arm926");
+ s->cpu = cpu_arm_init(current_machine->cpu_model);
Cheers,
C.
- Re: [Qemu-arm] [PATCH 1/6] palmetto-bmc: add a "silicon-rev" property at the soc level, (continued)
[Qemu-arm] [PATCH 2/6] palmetto-bmc: replace palmetto_bmc with aspeed, Cédric Le Goater, 2016/07/27
[Qemu-arm] [PATCH 4/6] palmetto-bmc: add board specific configuration, Cédric Le Goater, 2016/07/27
[Qemu-arm] [PATCH 3/6] ast2400: use machine cpu_model to initialize the soc cpu, Cédric Le Goater, 2016/07/27
[Qemu-arm] [PATCH 5/6] aspeed: add ast2500 support to scu and sdmc controllers, Cédric Le Goater, 2016/07/27
[Qemu-arm] [PATCH 6/6] arm: add support for an ast2500 evaluation board, Cédric Le Goater, 2016/07/27