Re: [Qemu-arm] [Qemu-devel] [PATCH] debugcon: Add -debugport option to allow changing debug console port number

[Zheng, Lv]

Hi,

> From: Igor Mammedov [mailto:address@hidden
> Subject: Re: [Qemu-devel] [PATCH] debugcon: Add -debugport option to
> allow changing debug console port number
> 
> On Fri,  5 Aug 2016 18:19:39 +0800
> Lv Zheng <address@hidden> wrote:
> 
> > Changing debugcon port to 0x402 allows the seabios AML table pre-
> defined
> > DBUG() control method to be able to dump the AML debugging
> information to
> > the re-directed debugging console.
> >
> > If the debug port number is configurable, users can further specify a
> > proper IO port number for it to make external BIOS's debugging
> > facility functioning.
> 
> there is no need for yet another CLI option that is being added here,
> just use usual '-device isa-debugcon,iobase=0x402,chardev=seabios"
> 

[Lv Zheng] 
OK, thanks for the information.

However, I feel that there are still improvements we can do here:
1. synchronizing DSDT's DBG operation region to debugcon iobase in acpi-build.c;
2. the readback should be automatically corrected by the isa-debugcon.iobase.
What do you think of this?
And if one of the above stuffs is useful, do you need me to send a revised 
patch?

Cheers
Lv