Re: [Qemu-arm] [Qemu-devel] [RFC PATCH v2 0/2] GICv3 live migration support

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [RFC PATCH v2 0/2] GICv3 live migration support

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
52635e4 hw/intc/arm_gicv3_kvm: Implement get/put functions
15053e8 kernel: Add definitions for GICv3 attributes

=== OUTPUT BEGIN ===
Checking PATCH 1/2: kernel: Add definitions for GICv3 attributes...
ERROR: code indent should never use tabs
#22: FILE: linux-headers/asm-arm64/kvm.h:183:
+^I(ARM64_SYS_REG_SHIFT_MASK(op0, OP0) | \$

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-headers/asm-arm64/kvm.h:211:
+#define   KVM_DEV_ARM_VGIC_SYSREG(op0,op1,crn,crm,op2) \
                                      ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-headers/asm-arm64/kvm.h:211:
+#define   KVM_DEV_ARM_VGIC_SYSREG(op0,op1,crn,crm,op2) \
                                          ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-headers/asm-arm64/kvm.h:211:
+#define   KVM_DEV_ARM_VGIC_SYSREG(op0,op1,crn,crm,op2) \
                                              ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-headers/asm-arm64/kvm.h:211:
+#define   KVM_DEV_ARM_VGIC_SYSREG(op0,op1,crn,crm,op2) \
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-headers/asm-arm64/kvm.h:212:
+                                       __ARM64_SYS_REG(op0,op1,crn,crm,op2)
                                                           ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-headers/asm-arm64/kvm.h:212:
+                                       __ARM64_SYS_REG(op0,op1,crn,crm,op2)
                                                               ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-headers/asm-arm64/kvm.h:212:
+                                       __ARM64_SYS_REG(op0,op1,crn,crm,op2)
                                                                   ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-headers/asm-arm64/kvm.h:212:
+                                       __ARM64_SYS_REG(op0,op1,crn,crm,op2)
                                                                       ^

total: 9 errors, 0 warnings, 38 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: hw/intc/arm_gicv3_kvm: Implement get/put functions...
ERROR: do not use C99 // comments
#291: FILE: hw/intc/arm_gicv3_kvm.c:300:
+        // TODO: there is no kernel API for reading/writing c->level

ERROR: do not use C99 // comments
#347: FILE: hw/intc/arm_gicv3_kvm.c:356:
+    // TODO: there is no kernel API for reading/writing s->level

total: 2 errors, 0 warnings, 512 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1