Re: [Qemu-arm] [PATCH v15 00/15] PTimer fixes/features and ARM MPTimer conversion

[Peter Maydell]

On 6 September 2016 at 11:32, Dmitry Osipenko <address@hidden> wrote:
> On 06.09.2016 01:12, Peter Maydell wrote:
>> I had a look at the rest of the patches, but to be honest I found
>> it very difficult to figure out whether any of the changes were
>> making the right changes or the wrong changes. So it's not clear
>> to me that "silence the warning if running under qtest" is right:
>> why is the warning being produced at all?
>>
>
> The ptimer tests cover all ptimer behaviour cases, including the cases where
> ptimer stops because of the error condition. This helps to ensure that further
> applied ptimer patches (like new policies) are not affecting old ptimer 
> (policy)
> behaviour, including those error cases. So the warning message is being 
> emitted
> each time some of the ptimer tests checks the error condition behaviour.

Oh, I see. Right, that's certainly OK to suppress warnings for.

> If you have any thoughts on how to make review of this series easier for you,
> please tell. I'm open to suggestions.
>
> BTW, I'm going to turn "Fix counter - 1 returned by ptimer_get_count for the
> active timer" patch into a ptimer policy. The patch is correct for all of the
> current ptimer users, however that "counter - 1" feature could be useful for
> some of the future added timers, like nios2 timer [0], and could be already 
> used
> by some of the QEMU forks. So it might be better to retain old behaviour for 
> the
> default policy.

Yes, if the patchset didn't change any behaviour for timers which
didn't request a non-default policy that would definitely help
in making me more confident it was safe.

thanks
-- PMM