[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/6] Pass generic CPUState to gen_
|
From: |
Lluís Vilanova |
|
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH v2 1/6] Pass generic CPUState to gen_intermediate_code() |
|
Date: |
Mon, 19 Sep 2016 14:14:14 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Richard Henderson writes:
> On 09/09/2016 06:03 AM, Lluís Vilanova wrote:
>> -void gen_intermediate_code(CPUAlphaState *env, struct TranslationBlock *tb)
>> +void gen_intermediate_code(CPUState *cpu, struct TranslationBlock *tb)
>> {
>> - AlphaCPU *cpu = alpha_env_get_cpu(env);
>> - CPUState *cs = CPU(cpu);
>> + CPUAlphaState *env = cpu->env_ptr;
> Why the variable renames? I.e. why CPUState *cpu instead of CPUState *cs?
It's the naming convention used on almost all other generic code in QEMU.
Cheers,
Lluis