qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH v3 2/2] ARM: Virt: ACPI: Build an IOR


From: Andrew Jones
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v3 2/2] ARM: Virt: ACPI: Build an IORT table with RC and ITS nodes
Date: Mon, 24 Oct 2016 14:45:55 +0200
User-agent: Mutt/1.6.0.1 (2016-04-01)

On Mon, Oct 24, 2016 at 01:29:42PM +0100, Peter Maydell wrote:
> On 17 October 2016 at 15:07, Andrew Jones <address@hidden> wrote:
> > On Mon, Oct 17, 2016 at 02:31:06PM +0200, Eric Auger wrote:
> >> From: Prem Mallappa <address@hidden>
> >>
> >> This patch builds an IORT table that features a root complex node and
> >> an ITS node. This complements the ITS description in the ACPI MADT
> >> table and allows vhost-net on ACPI guest.
> >>
> >> Signed-off-by: Prem Mallappa <address@hidden>
> >> Signed-off-by: Eric Auger <address@hidden>
> 
> >> @@ -667,17 +722,6 @@ void virt_acpi_build(VirtGuestInfo *guest_info, 
> >> AcpiBuildTables *tables)
> >>                               ACPI_BUILD_TABLE_FILE, tables_blob,
> >>                               64, false /* high memory */);
> >>
> >> -    /*
> >> -     * The ACPI v5.1 tables for Hardware-reduced ACPI platform are:
> >> -     * RSDP
> >> -     * RSDT
> >> -     * FADT
> >> -     * GTDT
> >> -     * MADT
> >> -     * MCFG
> >> -     * DSDT
> >> -     */
> >> -
> >
> > I guess it's still debatable if the above change should be a separate
> > patch or not. It'd probably be best if it was, or at least the commit
> > message should contain an 'Also ...' sentence. Anyway, I'll leave it
> > to the maintainers to decide.
> 
> Did you want to suggest a suitable addition to the commit message?
> I have no idea; I'm just going to apply these to target-arm on the
> basis of your review...

How about

"Also remove the comment block in virt_acpi_build that lists all the
 generated tables, rather than update it. It's redundant with the code,
 at best, and otherwise incomplete/misleading."

Thanks,
drew



reply via email to

[Prev in Thread] Current Thread [Next in Thread]